Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for v3 hardware #34

Merged
merged 4 commits into from
Oct 25, 2023
Merged

Add support for v3 hardware #34

merged 4 commits into from
Oct 25, 2023

Conversation

adrianstevens
Copy link
Collaborator

No description provided.

@adrianstevens adrianstevens marked this pull request as draft October 11, 2023 01:34
@adrianstevens adrianstevens marked this pull request as ready for review October 11, 2023 05:47
@adrianstevens adrianstevens changed the title Add support for v3 hardware (in-progress) Add support for v3 hardware Oct 11, 2023
hardware = new JuegoHardwareV2(ccm);
try
{
// hack for PWM init bug .... move back into the hardware classes once it's fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

id put a ToDo here to not forget to change this.

{
Resolver.Log.Error($"Err initializing I2C Bus: {e.Message}");
}
/* try - code left intentionally, restore once the PWM bug is fixed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Another ToDo here, perhaps

@adrianstevens adrianstevens merged commit 9814b75 into develop Oct 25, 2023
1 check passed
@adrianstevens adrianstevens deleted the v3 branch October 25, 2023 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants